bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch: Feature Branch - Windows Build Broken - config.h & relatives


From: Derek Robert Price
Subject: Re: Patch: Feature Branch - Windows Build Broken - config.h & relatives
Date: Thu, 24 Jun 2004 13:50:08 -0400
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Conrad T. Pino wrote:

>>I don't recall if you need to #define my_strftime to something.  Take
>>a cue from other files.
>
>
>Done as: #define my_strftime strftime


Actually, this needed to be something (pretty much anything) other
than "strftime" to avoid conflicting with the system strftime which
defining HAVE_STRFTIME causes my_strftime to use for much of the work.

>--------------------
>VC6 doesn't support C99 "restrict" key word.


I've committed your empty defiinition, but what about __restrict,
__restrict__, and _Restrict?  (See the test in m4/restrict.m4)

>The consequences of "HAVE_RUN_TZSET_TEST" change aren't totally clear
>to me and I'd welcome any feedback.


Defining this just allows strftime to compile since it relys on a
working tzset.  (When the m4/tzset.m4 macro determines that tzset
_does_ clobber localtime's buffer, it wraps the system tzset with a
function that saves and restores the buffer).

Thanks again for the patch!

Derek

- --
                *8^)

Email: address@hidden

Get CVS support at <http://ximbiot.com>!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFA2xRPLD1OTBfyMaQRAh8eAKDTvLwo9gNvppB2T4ENcNVM5wVQhQCg22fN
h2bvJ+aUqHU18orZ2LpEyW8=
=geYN
-----END PGP SIGNATURE-----





reply via email to

[Prev in Thread] Current Thread [Next in Thread]