bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Debian patches


From: Mark D. Baushke
Subject: Re: Debian patches
Date: Thu, 13 May 2004 11:13:18 -0700

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Steve McIntyre <address@hidden> writes:

> On Thu, May 13, 2004 at 02:28:16AM -0700, Mark D. Baushke wrote:
> >> #1: cvs.1 doesn't mention annotate
> >> ==================================
> >> http://www.einval.com/~steve/software/debian/cvs/patches/01_man_annotate.patch
> Cool. I'll have a look myself. Is that in ccvs now?

Yes.

> >> #3: allow :ext=<foo>
> >> ====================
> >> http://www.einval.com/~steve/software/debian/cvs/patches/03_ext_expansion.patch
> >> 
> >> Simple patch. Rather than have to set CVS_RSH in the environment,
> >> allow the CVSROOT to specify the ext method also.
> >
> >This is being handled in many different and mutually exclusive ways.
> >I suspect we are more likely to go to a :ext;command=foo: direction
> >of the CvsNT folks with a format like:
> >
> >    :ext[{program}][;command=value...]:address@hidden:]/path
> >
> >For example,
> >
> >    
> > :ext;command=/my/path/to/an/ssh/client/program:address@hidden:/path/to/CVSROOT
> >
> >see the method options processing in the root.c::parse_cvsroot()
> >function in top-of-tree cvs.cvshome.org for an example of what is
> >possible...
> 
> Aha! That looks excellent. Another wishlist bug against the Debian
> packages is a way of passing arguments to the CVS_RSH program, e.g. to
> specify a port number. Adding that may be tricky...

For ssh, this is typically done by having the host entry in your
$HOME/.ssh/config directory setup to use the proxy port. For example, I
use this:

Host anoncvs.usa.openbsd.org
    ForwardX11 no
    ForwardAgent no
    Port 2022

to be able to checkout and update my OpenBSD cvs files via CVS_RSH=ssh
when needed.

However, a more general solution for your problem might be:

     
:ext;command=joes-ssh-command;arg=-p;arg=2022:address@hidden:/path/to/cvsroot

which would might do something like

      joes-ssh-command -p 2022 cvs -l user server

as the remote command...


> >> #4: Newlines in checkin template
> >> ================================
> >> http://www.einval.com/~steve/software/debian/cvs/patches/04_newlines_in_commit_template.patch
> >> 
> >> Clean up newline-handling slightly when editing commit messages.
> >
> >I seem to recall getting shot down when I tried to add these newlines
> >back into cvs a while ago. The thought was that you could put what you
> >wanted into the rcsinfo template you are using...
> 
> True, but lots of people don't use templates. It would be nice for the
> default blank message to be easier to use.

Please discuss this with Larry and Derek... I tried to get them to
reverse the patch when the newline originally went missing before I
had commit access to the repository.

> >> #5: Alphanumerics in keywords
> >> =============================
> >> http://www.einval.com/~steve/software/debian/cvs/patches/05_keyword_alphanumerics.patch
> >> 
> >> It's useful to have alphanumerics rather than just alphabetics in
> >> custom keywords (consider XFree86)...
> >
> >I have no strong feelings about this patch, it seems reasonable, but
> >what do other folks think of it?

This also needs a sanity.sh test case.

> >> #7: More PAM work
> >> =================
> >> http://www.einval.com/~steve/software/debian/cvs/patches/07_PAM_changes.patch
> >> 
> >> Updates for PAM:
> >> 
> >> Add PamAuth and DefaultPamUser keywords to control PAM auth
> >> 
> >> PamAuth and SystemAuth can then be used for fine-grained control over
> >> authentication.
> >
> >Hmmm... I have no opinion on this one other than that I am not a fan of
> >having cvs support PAM in the first place...
> 
> Yes, I'd noticed. :-)

:-)

> >> #9: -l still causing problems
> >> =============================
> >> http://www.einval.com/~steve/software/debian/cvs/patches/09_noop_-l.patch
> >> 
> >> -l was re-added on the server, but can still cause client end
> >> problems. I've re-added it for the client too; it's simply a no-op at
> >> the moment.
> >
> >Yeah, I am not sure what to really do about the -l switch these days.
> 
> People were scared by the change, so it was easiest to add a no-op.

Yup. I removed the server warning at one site I maintian because of
complaints that 'cvs release' were generating warnings messages when
using older cvs clients...

        -- Mark
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)

iD8DBQFAo7q+3x41pRYZE/gRAu/9AJ4yG00x+lKhVNcKgj9hvO9q5dmCjQCgsBjd
f+D5+rC30uO19Xvvu09My0c=
=3SUC
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]