bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch for timezone handling in cvs log


From: Bart Robinson
Subject: Re: Patch for timezone handling in cvs log
Date: Thu, 29 Apr 2004 10:32:17 -0700 (PDT)

On 2004-4-29 Derek Robert Price <address@hidden> wrote:
 > address@hidden wrote:
 > 
 > >Derek Robert Price writes [quoting me]:
 > >
 > >>>Yes, that's the general concensus.  The only tricky part is that when
 > >>>you're *not* in client/server mode, there are no requests or responses
 > >>>-- the server is the client -- so you have to do it in the "server" in
 > >>>local mode but in the client in client/server mode.
 > >>
 > >>That is already handled on the local/server end by routing output
 > >>through cvs_output() & cvs_output_tagged().  Those functions just
 > >>print if the server is not active.
 > >
 > >
 > >That's what makes it tricky -- when you're in local mode, you don't
 > *want*
 > >to just print the UTC time, you want to convert it just like the client
 > >would have done had you been in client/server mode.
 > 
 > 
 > Ah, good point - I missed that.  Anyhow, that should be easily handled
 > with a simple switch on server_active in cvs_output_tagged().
 > 
 > Derek

Yes, if I'm talking about the same thing, I have to convert in
output_tagged as well as in handle_mt.

I send the GMT date in the current output form, YYYY/MM/DD HH.MM.SS
with a MT "date" tag.  If the client is old, it will just print it
like usual.  If the client supports it (and -z was given), it
will scan that and do the conversion in handle_mt.  If we are in
local mode, the conversion will be done in cvs_output_tagged
(and subsequently routed through cvs_output for the case of the
client not supporting the MT command at all.)

-- bart





reply via email to

[Prev in Thread] Current Thread [Next in Thread]