bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-gnulib] Re: fnmatch.c includes alloca.h conditionally?


From: Derek Robert Price
Subject: Re: [Bug-gnulib] Re: fnmatch.c includes alloca.h conditionally?
Date: Tue, 20 Apr 2004 20:57:16 -0400
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040413

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Paul Eggert wrote:

>Derek Robert Price <address@hidden> writes:
>
>>Actually, fnmatch.c still calls alloca() unconditionally, but it does
>>look to me like the dependency reference in modules/argp can be removed.
>>...
>
>
>>>Wouldn't it be simpler to change gl_FUNC_ALLOCA to always define
>>
>>HAVE_ALLOCA_H?
>>
>>This would work if you removed the #include <alloca.h> from
>>alloca_.h.  In this case, I should think alloca_.h should #define
>>HAVE_ALLOCA on platforms where it is deemed faster than malloc, such
>>as when #ifdef _MSC_VER, as well.
>
>
>Yes, that makes sense.
>
>How about this idea: wait a day or two for Bruno to comment, and if he
>doesn't then write up a patch?


Sounds good to me.

Derek

- --
                *8^)

Email: address@hidden

Get CVS support at <http://ximbiot.com>!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFAhcbrLD1OTBfyMaQRAmjmAJ9LfrC5VpM40QslSkRRhSAPDGkt3ACeKyCp
x69O/zhd65UFU3lV23EZakE=
=YckA
-----END PGP SIGNATURE-----





reply via email to

[Prev in Thread] Current Thread [Next in Thread]