bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Windows Build: lib/regex.c warnings, "free" calls


From: Derek Robert Price
Subject: Re: Windows Build: lib/regex.c warnings, "free" calls
Date: Wed, 07 Apr 2004 15:51:02 -0400
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Conrad T. Pino wrote:

>From prior messages I gather the project has a bias towards applying
>fixes at the highest level possible where it's most specific in order
>to minimize the unintended consequences.
>
>A cast can be applied at any of the 3 macros involved: REGEX_FREE,
>FREE_VAR and FREE_VARIABLES (ordered by lowest to highest nesting
>order).  Since the "...only if every call..." criteria is met in
>3 cases, we have 3 options:
>
>Door #1: A cast in REGEX_FREE (lowest level) is a 1 line change.
>
>Door #2: A cast in FREE_VAR (middle level) is a 1 line change.
>
>Door #3: Casts in FREE_VARIABLES (highest level) is a 7-9 line change.
>
>And now Derek Robert Price,
>which Door will it be?...
>Door #1? Door #2? OR Door #3?


I suppose I'd probably put it in FREE_VAR.  It seems to work with the
rest of the abstraction since it adds the rest of the cruft around
free() that the file likes to do every time.

Derek

- --
                *8^)

Email: address@hidden

Get CVS support at <http://ximbiot.com>!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Using GnuPG with Netscape - http://enigmail.mozdev.org

iD8DBQFAdFulLD1OTBfyMaQRAgwlAKCmDx5s3sobX+AvvIGta5fJ89zVfwCg+Jta
sN0GrZ2VzdaFNItm+7Dnw9s=
=7D8J
-----END PGP SIGNATURE-----






reply via email to

[Prev in Thread] Current Thread [Next in Thread]