[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch: Add support for CVS_USER environment variable
From: |
M . E . O'Neill |
Subject: |
Re: Patch: Add support for CVS_USER environment variable |
Date: |
Wed, 3 Mar 2004 14:35:33 -0800 |
I wrote:
If you don't want to accept the patch, it's not a huge loss to me.
... and Derek Price <derek@ximbiot.com> replied:
Great! Then you won't mind resubmitting your patch
Interesting logic. I gave you my patches as-is, in the hope they would
be useful. I have zero interest in being a CVS developer.
so that it only works in pserver mode as you specified
No, I never said my patch was intended for cvs servers running in `cvs
pserver' mode (which does authentication and knows what the usernames
are supposed to be). I said my patch was intended for cvs servers
running in `cvs server' mode, which always assumes that the username it
runs as is the correct username for commits.
Moreover, I am not convinced that the illusion of "security" provided
by limiting this patch to that case is worth anything whatsoever.
Similarly, about my other patch (honoring -q/-Q), Derek wrote:
would you mind updating the sanity.sh test cases to take account of
your changes, possibly answer Mark's other concerns below, and
resubmit your patch?
Yes, I would mind. I'd deleted my copy of the CVS sources before I
sent my patches. I'm done.
and with test cases and documentation, as requested in the HACKING
file in the top level of the CVS source distribution!
If I broke cvs hacking etiquette by just sending a patch, my apologies.
The message I'm getting here is that because I have neither the time
nor inclination to act as a champion and maintainer for my patches, I
shouldn't have bothered sending them in at all. Perhaps I should just
submit bug reports and feature requests without any code?
M.E.O.