bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: cvs-1.11.13 test failure (basic2-64)


From: Derek Robert Price
Subject: Re: cvs-1.11.13 test failure (basic2-64)
Date: Tue, 17 Feb 2004 16:44:32 -0500
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Paul Jarc wrote:

>address@hidden (Larry Jones) wrote:
>
>>Indeed.  If you're going to set $TESTDIR, you should set it to an actual
>>path, not one containing symlinks.
>
>
>I'd say a path containing symlinks is just as "actual" as any other,
>and I'd rather see this fixed than not.  But if not, I can live with
>that - I know why the test fails, I know it isn't a real problem, and
>I can work around it - but others might be confused, and more
>importantly, it seems this also causes all further tests to be
>skipped, which might hide a real problem.  Shouldn't the rest of the
>tests be performed regardless of whether this test fails?


I went to pretty great lengths recently to make sanity.sh symlink
agnostic, so I think that it is the test that is broken in this case,
not CVS.  I'm not certain, but it feels right that history should be
logging a true path and not indirections.

I think perhaps setting $NOLINK_TESTDIR and using those values for any
history tests would be appropriate.  Patches gleefully accepted!

Derek

- --
                *8^)

Email: address@hidden

Get CVS support at <http://ximbiot.com>!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Using GnuPG with Netscape - http://enigmail.mozdev.org

iD8DBQFAMos/LD1OTBfyMaQRArhiAJ9xlGhIp3omzGszV1Q+toHhDg/CigCg/N6W
VXRYkrT88dgQ6CSTQaKNcic=
=I/GF
-----END PGP SIGNATURE-----






reply via email to

[Prev in Thread] Current Thread [Next in Thread]