Re: problem with code 2003-10-27: CVS Feature Version 1.12.2 Released!

[Derek Robert Price]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Patrick Brown wrote:

>Sirs,
>I was attempting to build the code on windows.
>1)
>The files as in the project files *.dsp and dsw are in the unix file
format and need to be
>converted to windows format by a u2dos.


Did you check it out using CygWin?  CygWin CVS checks out with UNIX EOLs
but a version compiled with Windows will check them out with Windows
EOLs...  Oooh.  You mean the distribution files are in the wrong format,
don't you.  That is likely a good point.  Something will need to be
built into the makefile for a `make dist', or the files will need to be
tagged as binary.

>2)
>I found a problem config.h:
>#define SYSTEM_CLEANUP() wnt_cleanup()
>
>should read as
>#define  SYSTEM_CLEANUP wnt_cleanup


I think this is intentional.  If anyone defines SYSTEM_CLEANUP to accept
multiple arguments on some platforms, the first definition above will
cause the arguments to be ignored.

>3)
>The following code fragment is wrong from socket-client.c
>struct buffer *
>socket_buffer_initialize( int socket, int input,
>                          void *memory( struct buffer * ) )
>{
>    struct socket_buffer *n;
>
>    n = (struct socket_buffer *) xmalloc (sizeof *n);
>    n->socket = socket;
>    return buf_initialize (input ? socket_buffer_input : NULL,
>                input ? NULL : socket_buffer_output,
>               input ? NULL : socket_buffer_flush,
>               NULL,//(int (*) (void *, int))) NULL,
>               socket_buffer_shutdown,
>               memory,
>               n;
>}
>
>
>Do you have any idea what the fix for above is ?


What is wrong with it?

Derek

- --
                *8^)

Email: derek@ximbiot.com

Get CVS support at <http://ximbiot.com>!
- --
Old musicians don't die... they just decompose.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)
Comment: Using GnuPG with Netscape - http://enigmail.mozdev.org

iD8DBQE/ukKWLD1OTBfyMaQRAq2aAKCAlNSzygZiHaKv3At4lQpKiP19hwCeOkxz
cvdl9NeKTeYeecUc0SlRbjw=
=+sPZ
-----END PGP SIGNATURE-----