bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

lock_tree_for_write


From: Derek Robert Price
Subject: lock_tree_for_write
Date: Thu, 09 Oct 2003 14:51:11 -0400
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hey Larry,

Correct me if I am wrong, but there is no good reason for the
lock_tree_for_write calls in admin.c, edit.c, and watch.c.  The three
files contain four calls and all are of the form:

~    lock_tree_for_write
~    start_recursion(...CVS_LOCK_NONE...)
~    Lock_Cleanup

with no intervening calls.  I believe that in all four locations this
could be replaced with the single call to:

~    start_recursion(...CVS_LOCK_WRITE...)

and that this would be more efficient, allowing only a directory at a
time to be locked rather than locking an entire tree for the duration of
the entire operation.

Just wanted to run this by you before I changed those calls on stable.

P.S. If all your test platforms pass tonight I will release 1.11.9 by
Tuesday.  I think those last four fixes were significant enough to
justify the new release.

Derek

- --
~                *8^)

Email: address@hidden

Get CVS support at <http://ximbiot.com>!
- --
I saw nothing unusual in the teacher's lounge.
I saw nothing unusual in the teacher's lounge.
I saw nothing unusual in the teacher's lounge...

~          - Bart Simpson on chalkboard, _The Simpsons_
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)
Comment: Using GnuPG with Netscape - http://enigmail.mozdev.org

iD8DBQE/ha4eLD1OTBfyMaQRAu7vAJ9GIXSCdWnQ7MTTHLMCISjipWOtlACfdrJy
aepsUQbIIpWFqbFbEL+aplA=
=h0z7
-----END PGP SIGNATURE-----






reply via email to

[Prev in Thread] Current Thread [Next in Thread]