bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] importinfo/admininfo


From: Derek Robert Price
Subject: Re: [PATCH] importinfo/admininfo
Date: Sat, 04 Oct 2003 17:39:35 -0400
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ralf S. Engelschall wrote:

|On Sat, Oct 04, 2003, Mark D. Baushke wrote:
|
|>>On Sat, Oct 04, 2003, Mark D. Baushke wrote:
|>>
|>>>I have dropped address@hidden from the CC list of this message.
|>>>I am just pointing out trivial coding sytle problems here...


At some point Ralph should submit the complete patch to address@hidden
(as opposed to info-cvs or directly to us) with the understanding that
such a submission is considered explicit release of your code under the
GNU GPL and thus permission to include it in CVS, as per HACKING.

|>Are the '(char *)' casts around (char *)NULL really necessary?
|>(I am asking, not necessarily suggesting that you change them.)
|
|
|They should be not really necessary with a C compiler, but for C++
|compilers they sometimes are. But I've just followed the style which is
|used in other calls to start_recusion() throughout CVS.


Actually, I started removing such casts a few days ago when neither
Larry nor Mark could tell me why I shouldn't.  I believe casts of NULL
and casts of pointers to void * are unecessary under C89, though I
couldn't find explicit mention of this, it's just been a long time since
I've seen a compiler that complained.

Can you name a compiler that would complain?  If it is a C++ compiler,
is there a good reason we should support it in the CVS source?

Derek

- --
~                *8^)

Email: address@hidden

Get CVS support at <http://ximbiot.com>!
- --
I will not fake my way through life.
I will not fake my way through life.
I will not fake my way through life...

~          - Bart Simpson on chalkboard, _The Simpsons_
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)
Comment: Using GnuPG with Netscape - http://enigmail.mozdev.org

iD8DBQE/fz4WLD1OTBfyMaQRAiBbAKDTkVDm0ab7s8wFyVVTZ5jtNI4lRgCgpD87
7tZVqkZIAp8QxXxuIGRWp5Q=
=n6Xx
-----END PGP SIGNATURE-----






reply via email to

[Prev in Thread] Current Thread [Next in Thread]