[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Is there really any interest in a patch to allow cvs 1.11.6 to run

From: Derek Robert Price
Subject: Re: Is there really any interest in a patch to allow cvs 1.11.6 to run
Date: Fri, 03 Oct 2003 11:47:33 -0400
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1

Hash: SHA1

Kelly F. Hickel wrote:

|FAIL: basica-6.2
|make[2]: *** [localcheck] Error 1
|make[2]: Leaving directory `/usr/local/cvs/cvs-1.11.6_nsk/src'
|make[1]: *** [check-am] Error 2
|make[1]: Leaving directory `/usr/local/cvs/cvs-1.11.6_nsk/src'
|make: *** [check-recursive] Error 1
|/usr/local/cvs/cvs-1.11.6_nsk: |
|How much does this matter?

If there are any sanity.sh tests failing, your fix is wrong because it
breaks another part of CVS and the fix will not be accepted.

|   I still haven't gotten any good feeling
|from someone who actually has the power to put my patches into the
|source that they're interested in doing so....
|I'm about to upgrade the OS to the latest version, so I want to wait
|any make sure that the unmodified source still has problems on the
|latest version, then I'll be ready to send out the (relatively small)

Per the HACKING in the top level of the CVS source distribution:

|The general rule for portability is that it is only worth including
|portability cruft for systems on which people are actually testing and
|using new CVS releases.  Without testing, CVS will fail to be portable
|for any number of unanticipated reasons.

This means that unless we see that Tandem gets regular testing, the CVS
developers are unlikely to feel that your patch is useful even if it
begins to work since it will likely not stay useful for long.

i.e. If somebody is not running nightly testing on the system, then it
is much easier for another developer to check in a fix for something
else that breaks your portability cruft but which is not spotted until
you tell it's broken after the next CVS release.

The exception to this rule can be when you can find a fix already
incorporated in some GNULIB module we use (or get your fix incorporated
into GNULIB).  We hope to pick up portability cruft from GNULIB that we
might not actually be testing but which gets testing elsewhere.

- --
~                *8^)

Email: address@hidden

Get CVS support at <http://ximbiot.com>!
- --
I will not buy a presidential pardon.
I will not buy a presidential pardon.
I will not buy a presidential pardon...

   - Bart Simpson on chalkboard, _The Simpsons_
Version: GnuPG v1.0.7 (GNU/Linux)
Comment: Using GnuPG with Netscape - http://enigmail.mozdev.org


reply via email to

[Prev in Thread] Current Thread [Next in Thread]