bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: assertion fault. on loggin


From: Paul Edwards
Subject: Re: assertion fault. on loggin
Date: Wed, 17 Sep 2003 19:34:54 GMT

"Pierre" <address@hidden> wrote in message news:address@hidden
> > It has the assertion failure on the first go?  Then what's the point
> > of running it 1000 times?!
>
> I was thinking the bug behaviour was to not survive early fstat.

No.  The bug is now reproducible, happens first time you
run the program.  That's great.

> > But I need to see the output from the last patch.  I need to know
> > what was printed before the assertion failure, that's the whole
> > point of the test.
>
> It's the same :
>
> early fstat of 4
> survived early fstat
> Le sous-programme assert a ÚchouÚ : fstat ( fileno (bc->fp), &s ) != -1, 
> fichier
>  buffer.c, ligne 1386
> cvs [login aborted]: received abort signal
>
> (No much difference between the two patches !)

That's fine, progress is being made.  There's method to the madness. :-)

Try latest patch.  Very close now.  Only need about 2-3 more results.

BFN.  Paul.


Index: buffer.c
===================================================================
RCS file: /cvs/ccvs/src/buffer.c,v
retrieving revision 1.21.4.1
diff -c -r1.21.4.1 buffer.c
*** buffer.c 17 Feb 2003 21:19:12 -0000 1.21.4.1
--- buffer.c 17 Sep 2003 19:31:11 -0000
***************
*** 1371,1376 ****
--- 1371,1377 ----
  }


+ extern struct stdio_buffer_closure *ugly_hack;

  static int
  stdio_buffer_shutdown (buf)
***************
*** 1380,1385 ****
--- 1381,1387 ----
      struct stat s;
      int closefp = 1;

+     sleep(5);
      /* Must be a pipe or a socket.  What could go wrong? */
      assert (fstat ( fileno (bc->fp), &s ) != -1);

***************
*** 1464,1473 ****
--- 1466,1485 ----
   buf->output = NULL;
      }

+     /* no problem here */
+
      if (closefp && fclose (bc->fp) == EOF)
   error (1, errno,
          "closing down connection to %s",
          current_parsed_root->hostname);
+
+     if (ugly_hack != NULL)
+     {
+         printf("early fstat of %d\n", fileno(ugly_hack->fp));
+         sleep(5);
+         assert (fstat ( fileno (ugly_hack->fp), &s ) != -1);
+         printf("survived early fstat\n");
+     }

      /* If we were talking to a process, make sure it exited */
      if (bc->child_pid)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]