Re: getline & getline_safe

[Paul Edwards]

"Derek Robert Price" <derek@ximbiot.com> wrote in message 
news:mailman.447.1059051115.8231.bug-cvs@gnu.org...
> > I think it is usual for a program to have processing restrictions,
> >
> >although I would have made it based on a CVS-controlled define,
> >like CVS_STR_LIMIT, rather than PATH_MAX, which could
> >potentially be 8, while userid may be 30.
> >
> >
> I don't think you're going to find many PATH_MAX's under 256.  I think UNIX 
> and Windows both have PATH_MAXs of 4096?

CVS runs under DOS too.  MVS is/was restricted to 44/52.

> In any case, specifying the CVSROOT is part of the authentication phase and 
> needs to be limited by PATH_MAX.  Since that is the
largest potential string passed during authentication, I think the use of 
PATH_MAX simply cascaded as sufficient.

I agree that CVSROOT should be PATH_MAX, or actually, I
think it should be FILENAME_MAX, but the other strings are
not logically related to filenames and thus should be separately
defined.  Maybe I wouldn't be so anal to create a USERID_MAX,
WHATEVER_MAX, but I would separate filenames that aren't
actually stored in the ",v" file to strings that are.  I see those as
very different things.

PATH_MAX varies based on the system, CVS strings vary
based on application limits in the ",v" file.  I don't have a
problem with "userid" being defined in CVS as "first 500
characters of user identification string provided by remote,
ignoring commas and various other characters that interfere
with CVS's internal storage use" etc etc.  I think this is quite
normal for an application to restrict.

BFN.  Paul.