bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Compile error in current CVS, src/server.c:5500


From: Derek Robert Price
Subject: Re: Compile error in current CVS, src/server.c:5500
Date: Mon, 21 Jul 2003 09:25:29 -0400
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1

Mark D. Baushke wrote:

Hi Pavel,

Actually, your patch is not yet consistent with the need to deal with
pre-ANSI compilers (altough much of those requirements appear to have
been dropped recently). In any case, the error needs to be structured a
bit differently with the 'error' keyword on the second line and return
value provided as well.


Yeah, and I was in the not particularly hurried process of removing more of them. As I understand from the discussion in the GNULIB forum, HP-UX is the last system anyone there will mention to ship with a K&R compiler and even GCC isn't supporting K&R compilers anymore. If an HP-UX admin doesn't buy the commercial HP-UX compiler they need to bootstrap even gcc with an old version of GCC.

We also use GNULIB modules which no longer support K&R (none of GNULIB does) and if we really need to we (or an end user) could resort to automake's automatic support of the ansi2knr script.

Do you know when split strings began being supported? C89? I had noticed that I was getting deprecation warnings for multi-line strings from gcc 3.2.2 on the one machine I have it installed on. I didn't know 3.3 rejected them.

To be honest, I wonder why the result of pam_end() is not being captured
and causing a call to pam_strerror().


I'll second that.

I think that Derek Price or Brian Murphy need to resolve how they want
this to be handled. So, I'll let them worry about it. Thanks for your
bug report.

        Enjoy!
        -- Mark

Index: server.c
===================================================================
RCS file: /cvs/ccvs/src/server.c,v
retrieving revision 1.301
diff -u -p -r1.301 server.c
--- server.c    20 Jul 2003 16:38:55 -0000      1.301
+++ server.c    20 Jul 2003 22:36:20 -0000
@@ -5497,8 +5497,8 @@ check_system_password (username, passwor

    if (pam_end(pamh,retval) != PAM_SUCCESS)
    {
-       printf("E Fatal error, aborting.\n
-               pam failed to release authenticator\n");
+       printf("E Fatal error, aborting.\n\
+error EACCES pam failed to release authenticator\n");
        error_exit ();
    }




Pavel Roskin <address@hidden> writes:

Hello!

The current CVS doesn't compile with gcc-3.3:
server.c:5500:16: missing terminating " character
server.c:5501:54: missing terminating " character

Fix:
======================================
--- src/server.c
+++ src/server.c
@@ -5497,8 +5497,8 @@ check_system_password (username, passwor

    if (pam_end(pamh,retval) != PAM_SUCCESS)
    {
-       printf("E Fatal error, aborting.\n
-               pam failed to release authenticator\n");
+       printf("E Fatal error, aborting.\n"
+               "pam failed to release authenticator\n");
        error_exit ();
    }

======================================

--
Regards,
Pavel Roskin



_______________________________________________
Bug-cvs mailing list
address@hidden
http://mail.gnu.org/mailman/listinfo/bug-cvs



_______________________________________________
Bug-cvs mailing list
address@hidden
http://mail.gnu.org/mailman/listinfo/bug-cvs

--
               *8^)

Email: address@hidden

Get CVS support at <http://ximbiot.com>!
--
77. (D)inner not ready: (A)bort, (R)etry, (P)izza?






reply via email to

[Prev in Thread] Current Thread [Next in Thread]