Re: [PATCH] move rsh client code to rsh-client.[ch]

[Alexey Mahotkin]

>>>>> "DRP" == Derek Robert Price <derek@ximbiot.com> writes:

 >> Move rsh (:ext:) client stuff to rsh-client.[ch]

 DRP> Committed.

Finally, this is a fix to rsh-client:

2003-05-07  Alexey Mahotkin <alexm@hsys.msk.ru>

Add missing #include;

add _p prefix to_/from_server


 src/client.c     |    1 +
 src/rsh-client.c |   16 ++++++++--------
 2 files changed, 9 insertions(+), 8 deletions(-)

--- ccvs/src/rsh-client.c~rsh-client-fix        Wed May  7 21:34:05 2003
+++ ccvs-alexm/src/rsh-client.c Wed May  7 21:35:37 2003
@@ -35,10 +35,10 @@
    up and running, and that's most important. */
 
 void
-start_rsh_server (root, to_server, from_server)
+start_rsh_server (root, to_server_p, from_server_p)
     cvsroot_t *root;
-    struct buffer **to_server;
-    struct buffer **from_server;
+    struct buffer **to_server_p;
+    struct buffer **from_server_p;
 {
     int pipes[2];
     int child_pid;
@@ -114,16 +114,16 @@ start_rsh_server (root, to_server, from_
        error (1, errno, "cannot start server via rsh");
 
     /* Give caller the file descriptors in a form it can deal with. */
-    make_bufs_from_fds (pipes[0], pipes[1], child_pid, to_server, from_server, 
0);
+    make_bufs_from_fds (pipes[0], pipes[1], child_pid, to_server_p, 
from_server_p, 0);
 }
 
 # else /* ! START_RSH_WITH_POPEN_RW */
 
 void
-start_rsh_server (root, to_server, from_server)
+start_rsh_server (root, to_server_p, from_server_p)
     cvsroot_t *root;
-    struct buffer **to_server;
-    struct buffer **from_server;
+    struct buffer **to_server_p;
+    struct buffer **from_server_p;
 {
     /* If you're working through firewalls, you can set the
        CVS_RSH environment variable to a script which uses rsh to
@@ -186,7 +186,7 @@ start_rsh_server (root, to_server, from_
     }
     free (command);
 
-    make_bufs_from_fds (tofd, fromfd, child_pid, to_server, from_server, 0);
+    make_bufs_from_fds (tofd, fromfd, child_pid, to_server_p, from_server_p, 
0);
 }
 
 # endif /* START_RSH_WITH_POPEN_RW */
--- ccvs/src/client.c~rsh-client-fix    Wed May  7 21:34:45 2003
+++ ccvs-alexm/src/client.c     Wed May  7 21:35:08 2003
@@ -28,6 +28,7 @@
 # include "md5.h"
 
 #include "socket-client.h"
+#include "rsh-client.h"
 
 # if HAVE_KERBEROS
 

_


--alexm