bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

code review needed for a possible cvs1-11-x-branch fix


From: Mark D. Baushke
Subject: code review needed for a possible cvs1-11-x-branch fix
Date: Mon, 17 Mar 2003 08:24:23 -0800

Hi Folks,

I just committed a patch similar to this to the top-of-tree along with a
test case that proves to me that it does the right thing. However, I
have not actually tripped over this error in the cvs 1.11.5 yet
(although I am trying various things to trigger it), so I do not have
any material for altering the sanity.sh file.

I would greatly appreciate if someone who really understands the
client/server stuff could take a look and see what you think of it.

After applying this patch, everything in 'make check' still works
as expected on a Redhat 7.3 GNU/Linux system.

The real question is when does buf_send_counted() need to be called?
Why should not having a particular tag in the val-tags file have caused
the problem which led to the similar patch in the trunk?

        Thanks,
        -- Mark

ChangeLog entry:
2003-03-14  Mark D Baushke <address@hidden>

        * server.c (template_proc): Fix client/server protocol
        problem. Make sure that buf_send_counted() is called after the
        last of the Template file has been sent.

Index: src/server.c
===================================================================
RCS file: /cvs/ccvs/src/server.c,v
retrieving revision 1.284.2.1
diff -u -p -r1.284.2.1 server.c
--- src/server.c        21 Feb 2003 21:32:55 -0000      1.284.2.1
+++ src/server.c        14 Mar 2003 10:04:23 -0000
@@ -4412,6 +4412,7 @@ template_proc (repository, template)
            return 1;
        }
     }
+    buf_send_counted (protocol);
     if (fclose (fp) < 0)
        error (0, errno, "cannot close rcsinfo template file %s", template);
     return 0;




reply via email to

[Prev in Thread] Current Thread [Next in Thread]