bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: cvs 1.11.2 buffer.c blocking socket/pipe w/bugfix


From: Peter Wemm
Subject: Re: cvs 1.11.2 buffer.c blocking socket/pipe w/bugfix
Date: Sat, 19 Oct 2002 11:09:23 -0700

Larry Jones wrote:
> Derek Robert Price writes:
> > 
> > Can you suggest an alternative to get around the blocking problem?
> 
> It looks to me like we're just screwed.  The problem is that when old
> clients use compression, they don't actually close the connection to the
> server until after the server closes its connection to them.  The old
> server didn't check for EOF on the input stream before closing it, so it
> didn't matter, but the new server does and thus hangs.
> 
> I think our best course of action is to just remove the EOF check from
> the input buffer case in stdio_buffer_shutdown(), which was the
> originally suggested fix.  I don't like it, the old client behavior is
> clearly wrong, but I think it's the lesser of two evils.

Was there an outcome to solve this problem?  The "fix" that we're using on
freebsd.org is clearly wrong and seems to cause all sorts of nastiness
including reports of 'broken pipe' and the server spinning consuming 100%
of cpu.   I'm thinking of backing out to 1.11.1-p1+hacks since we didn't
have the problem there.

Cheers,
-Peter
--
Peter Wemm - address@hidden; address@hidden; address@hidden
"All of this is for nothing if we don't go to the stars" - JMS/B5





reply via email to

[Prev in Thread] Current Thread [Next in Thread]