Re: case insensitive problem on win32 client

[Brad L. Chisholm]

We ran into this a while ago.  It's been a problem since at least
1.10.7, although it didn't assert back then, it just gave stat errors.

I believe the problem is that RCS_parse() (in rcs.c) supports case
insensitive filename comparisons, but locate_rcs() (in commit.c)
does not.  On the first pass through, RCS_parse() is called.  It
does a case-insensitive match, which matches a previously removed
file.  Later on, locate_rcs() is called, which does *not* perform
a case-insensitive match, so the RCS file cannot be located.  This
causes an inconsistency which later results in the assertion you are
seeing.

I believe making locate_rcs() support case-insensitive clients
should solve the problem, although it might not have the desired
effect, since adding 'File.c' after deleting 'file.c' will result
in resurrecting 'file.c' when CVS is used from a case-insensitive
client.

The real fix is to use an operating system which fully supports
case-sensitive file names (eg. Unix).

-Brad

On Tue, May 22, 2001 at 05:56:58PM +0200, Benoît Rouits wrote:
> OK, i think i found where to hack : add.c line 518 :
> "re-adding file %s (in place of dead revision %s)"
> this is the message given by CVS when we do the 
> cvs add file.txt after deleting FILE.TXT
> Benoît Rouits wrote:
> > 
> > Hi,
> > I would like to refresh a problem seen on :
> > http://mail.gnu.org/pipermail/bug-cvs/2000-November/005013.html
> > 
> > I have the same problem with a win32 client. this is caught in
> > the assertion:
> > (file commit.c)
> > (line 2054)
> > if (rcsnode != NULL)
> > {
> >     assert (*rcsnode == NULL);
> >     *rcsnode = rcsfile;
> > }
> > 
> > I would like to make a personnal patch to correct this
> > problem. Can somebody help me to fix this ? Many thanks,
> > Ben
> > 
> > _______________________________________________
> > Bug-cvs mailing list
> > Bug-cvs@gnu.org
> > http://mail.gnu.org/mailman/listinfo/bug-cvs
> 
> -- 
>         Benoit Rouits         | Tel : (+33) 1 4922 7719
> Open Source Software Engineer | http://www.alcove.com
> 
> _______________________________________________
> Bug-cvs mailing list
> Bug-cvs@gnu.org
> http://mail.gnu.org/mailman/listinfo/bug-cvs