bug-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

CVS 'tag' command does not write 'T' record to history


From: Yair Lenga
Subject: CVS 'tag' command does not write 'T' record to history
Date: Thu, 05 Apr 2001 10:08:51 -0400

Greetings!,

We are using the 'TAG' command to manage released code. The documentation 
indicates that tag updates
will be included in the history file by default (or by adding 'T' to the 
logHistory option in the config file).

We found two bugs:

1. The 'tag' command does not place any record in the history file. Looking 
into the 1.11 source code, I could
not find any call to 'write_history' inside the 'tag.c' module.

2. The 'rtag' command place a single 'T' record into the history file per each 
module. The 'T' record is placed
per module, even if the command fail completed.

My best guess for solutions are:

For (1), a call to write_history should be placed into tag_fileproc for two 
cases:
1a. When a tag is removed from a file (line #516).
1b. When a tag is entered into a file (line #634).

For (2), the existing call to write_history should be replaced with a per file 
logging:
2a. When a tag is removed from a file 'rtag_delete' should call write_history 
(and possibly generating a 'D' output
line for consistency with 'tag').
2b. After a successful call to 'RCS_settag', write_history should be called 
(and possibly generating a 'T' output line
line for consistency with 'tag).

Any feedback will be appreciated.
Yair Lenga
yair.lenga@ssmb.com





reply via email to

[Prev in Thread] Current Thread [Next in Thread]