Re: Freeing non-heap pointer in normalize_cvsroot

[Derek R. Price]

Jon Miner wrote:

> In normalize_cvsroot, free_port_s is no longer needed (and in fact
> creates a call to free() with stack memory..)

Fixed.  Thanks.


> "normalizing" also creates a problem with CVSROOTs and CVS/Root and
> ~/.cvspass files that don't have the port number in them..  It will
> never match with the ~/.cvspass password (in get_cvs_password) until it
> is checked-out again.  An explicit login with the _full_ repository name
> (including port) does seem to fix the problem..

Actually, you shouldn't need the port in the login unless you don't want to
use the default.  That was the point of the change.  Assuming you were
logged into a machine as dprice, the following are now equivalent
repository names:

    :pserver:cvs.cvshome.org/home2/cvsroot
    :pserver:dprice@cvs.cvshome.org/home2/cvsroot
    :pserver::password@cvs.cvshome.org/home2/cvsroot
    :pserver:dprice@cvs.cvshome.org:/home2/cvsroot
    :pserver:dprice@cvs.cvshome.org:2401/home2/cvsroot

But, they would all use the following entry in .cvspass:

    :pserver:dprice@cvs.cvshome.org:2401/home2/cvsroot

The line with the password was part of my motivation for normalizing.
Seems kinda silly to leave that in .cvspass and it invalidates the
scrambling.  Anyhow, a logout should remove the defunct entries from
~/.cvspass, but a new login is required whether they are there or not.  It
didn't seem worth the effort of extra parsing of the .cvspass file for
backwards compatibility as there's not really any way to know that the lack
of a port number in there is referring to 2401 or some other default port
the client was compiled with.

There's a comment in the NEWS file about all this already.

Derek

--
Derek Price                      CVS Solutions Architect ( http://CVSHome.org )
mailto:dprice@openavenue.com     OpenAvenue ( http://OpenAvenue.com )
--
I will not yell "Fire" in a crowded classroom.
I will not yell "Fire" in a crowded classroom.
I will not yell "Fire" in a crowded classroom...

          - Bart Simpson on chalkboard, _The Simpsons_