bug-cpio
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-cpio] Some integer fixes


From: Pavel Raiskup
Subject: Re: [Bug-cpio] Some integer fixes
Date: Fri, 31 Jan 2014 11:46:51 +0100
User-agent: KMail/4.11.5 (Linux/3.12.8-300.fc20.x86_64; KDE/4.11.5; x86_64; ; )

On Monday, September 23, 2013 17:31:45 Pavel Raiskup wrote:
> [PATCH 1/2] Use ssize_t for input buffer size
> 
> Fix for crash reported at https://bugzilla.redhat.com/996150
> 
> [PATCH 2/2] cpio: cleanup gcc -Wall warnings
> 
> Just some cleanup.

Could we apply at least the first patch?  That fixes not nice segfault
caused by `find /sys | ./src/cpio -o > a.cpio`.  That is caused because
cpio is unable to handle negative error value from read(), look at:

  src/util.c:229: input_size = read (in_des, input_buffer, num_bytes);

The second patch is not so important but it is usual to use -Wall option.
So please consider.  Both patches are re-attached reformatted against
current HEAD.

Pavel

Attachment: 0001-Use-ssize_t-for-input-buffer-size.patch
Description: Text Data

Attachment: 0002-cpio-cleanup-gcc-Wall-warnings.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]