bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#32236: df header corrupted with LANG=zh_TW.UTF-8 on macOS


From: Paul Eggert
Subject: bug#32236: df header corrupted with LANG=zh_TW.UTF-8 on macOS
Date: Thu, 26 Jul 2018 18:23:02 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

Pádraig Brady wrote:
I've pushed the c_iscntrl patch since it's simplest
and probably most appropriate patch for an existing release.

Yes, that makes sense for a quick patch. However, for the next release I think it'd be better to catch encoding errors and multibyte control characters, given the problems noted. I installed the attached further patch to try to do this. This fixes the problem that Bruno noted, along with two others; my earlier patch neglected the possibility that mbrtowc can return 0, and it incorrectly assumed wide control characters always have a single-byte representation.

Either way the original bug appears to be fix so I'm boldly closing the bug 
report.

Attachment: 0001-df-avoid-multibyte-character-corruption-on-macOS.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]