bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#27368: Minor concern: Confusing tail warning


From: Pádraig Brady
Subject: bug#27368: Minor concern: Confusing tail warning
Date: Sat, 17 Jun 2017 14:30:29 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

On 17/06/17 07:35, Jim Meyering wrote:
> On Sat, Jun 17, 2017 at 1:32 AM, Pádraig Brady <address@hidden> wrote:
> ...
>> Two proposed patches for this are attached.
> 
> Nice fixes. Thank you!
> 
> In the NEWS addition:
> 
>    tail -f will now exit immediately if the output is piped
>    and the reader of the pipe terminates.
> 
> +  tail -f will no longer erroneously warn about being ineffective
> +  when following a single tty, as the simple blocking loop used
> +  is effective in this case.

> Please don't use "will" in [NEWS].
> I.e., use the present tense instead. Referencing the future makes
> sense only now, prior to the release.
> 
> ----------------------
> In this new function, please move the declaration of "i" into the for-loop:
> 
> +static bool
> +any_non_regular (const struct File_spec *f, size_t n_files)
> +{
> +  size_t i;
> +
> +  for (i = 0; i < n_files; i++)
> 

Cool.
Thanks for the review





reply via email to

[Prev in Thread] Current Thread [Next in Thread]