bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#14897: dd skip exit code


From: Bernhard Voelker
Subject: bug#14897: dd skip exit code
Date: Thu, 18 Jul 2013 23:43:15 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5

On 07/18/2013 07:52 PM, Pádraig Brady wrote:

> * NEWS: Mention the change in behavior

s/$/./

> @@ -2010,7 +2013,9 @@ dd_copy (void)
>  
>        if (nread < 0)
>          {
> -          error (0, errno, _("error reading %s"), quote (input_file));
> +          if (!(conversions_mask & C_NOERROR) || !(status_flags & 
> STATUS_NONE))
> +            error (0, errno, _("error reading %s"), quote (input_file));
> +
>            if (conversions_mask & C_NOERROR)
>              {
>                print_stats ();

This doesn't look like a non-fatal error to me.  Are you sure
we really want to suppress this with status=none?

Reading the Texinfo manual, I think this change in behavior should
also be documented:

          Do not print any informational messages to stderr.  Error
          messages are output as normal.

It probably should say something like "... any informational nor
warning messages ...".

Otherwise +1.

Have a nice day,
Berny





reply via email to

[Prev in Thread] Current Thread [Next in Thread]