[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#9157: [PATCH] dd: sparse conv flag
From: |
Paul Eggert |
Subject: |
bug#9157: [PATCH] dd: sparse conv flag |
Date: |
Mon, 27 Feb 2012 07:50:16 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 |
Thanks for looking into this! Some nits:
On 02/27/2012 07:20 AM, Pádraig Brady wrote:
> +is_nul (const char* buf, size_t bufsize)
The usual spacing style is "const char *buf", since the
"*" really belongs to the "buf" in C.
> + memset (obuf + output_blocksize, 1, sizeof (uintptr_t));
This constraint on OUTPUT_BLOCK_SLOP should be documented, thus:
#define OUTPUT_BLOCK_SLOP MAX (sizeof (uintptr_t), page_size - 1)
> + /* write sentinel to slop after the buffer,
> + to allow efficient checking for NUL blocks. */
Initial cap for sentence. The next comment has a similar issue.
- bug#9157: [PATCH] dd: sparse conv flag, Pádraig Brady, 2012/02/27
- bug#9157: [PATCH] dd: sparse conv flag,
Paul Eggert <=
- bug#9157: [PATCH] dd: sparse conv flag, Pádraig Brady, 2012/02/27
- bug#9157: [PATCH] dd: sparse conv flag, Paul Eggert, 2012/02/27
- bug#9157: [PATCH] dd: sparse conv flag, Pádraig Brady, 2012/02/27
- bug#9157: [PATCH] dd: sparse conv flag, Pádraig Brady, 2012/02/27
- bug#9157: [PATCH] dd: sparse conv flag, Paul Eggert, 2012/02/28
- bug#9157: [PATCH] dd: sparse conv flag, Pádraig Brady, 2012/02/28
- bug#9157: [PATCH] dd: sparse conv flag, Pádraig Brady, 2012/02/28
- bug#9157: [PATCH] dd: sparse conv flag, Paul Eggert, 2012/02/28
- bug#9157: [PATCH] dd: sparse conv flag, Pádraig Brady, 2012/02/28
- bug#9157: [PATCH] dd: sparse conv flag, Roman Rybalko, 2012/02/28