Re: --enable-xattr gives #define USE_XATTR yes instead of 1

[Pádraig Brady]

On 11/03/10 03:37, Mikael Magnusson wrote:
> Which on my new system causes the check in src/cp.c #if !USE_XATTR to
> be true and makes cp bail out when trying to preserve attributes.
> Changing it to 1 in lib/config.h "fixes" it.
>
> % grep AC_DEFINE.\*USE m4/*.m4
> m4/acl.m4:  AC_DEFINE_UNQUOTED([USE_ACL], [$use_acl],
> m4/threadlib.m4:                 AC_DEFINE([PTHREAD_IN_USE_DETECTION_HARD], [1],
> m4/threadlib.m4:          AC_DEFINE([USE_POSIX_THREADS], [1],
> m4/threadlib.m4:              AC_DEFINE([USE_POSIX_THREADS_WEAK], [1],
> m4/threadlib.m4:          AC_DEFINE([USE_SOLARIS_THREADS], [1],
> m4/threadlib.m4:            AC_DEFINE([USE_SOLARIS_THREADS_WEAK], [1],
> m4/threadlib.m4:        AC_DEFINE([USE_PTH_THREADS], [1],
> m4/threadlib.m4:            AC_DEFINE([USE_PTH_THREADS_WEAK], [1],
> m4/threadlib.m4:          AC_DEFINE([USE_WIN32_THREADS], [1],
> m4/unlocked-io.m4:  AC_DEFINE([USE_UNLOCKED_IO], [1],
> m4/xattr.m4:    AC_DEFINE_UNQUOTED([USE_XATTR], [$use_xattr],
>
> The first and last one of those should probably be 1, not $use_foo?
> Actually acl.m4 sets it to 1, not yes, so that should be working fine
> (I don't use ACL myself though).
>
> I can't figure out why it breaks on that machine though, I assume it
> works for a lot of people, and neither the m4 file nor cp.c has
> changed on those lines since xattr support was added... Disclaimer:
> this is gentoo ;).

Yes 8.4 has this issue. It was fixed with:
http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=e489fd04d66000829f5458843970794eccacced8

cheers,
Pádraig.