Re: expr say "non integer argument"

[Eric Blake]

According to Eric Blake on 2/25/2010 8:41 AM:
> According to Eric Blake on 2/18/2010 7:18 AM:
>> According to address@hidden on 2/18/2010 6:54 AM:
>>> EB> jidanni, it would be a two-line patch to expr.c.  Would you care to 
>>> write
>>> EB> such a patch, rather than just complaining?
>>>
>>> It would be much more efficient for me to just play the role of the bug
>>> reporter here.... trust me. Thanks.
>>
>> You are giving up too easily.  Your bug reports would go a LOT further if
>> you would show some effort behind them.
> 
> Your suggestion wasn't all that bad, but I still stand by my position that
> you should do more work than just complain.  But I had some time available
> while cleaning out my inbox, and I was feeling generous, so I finished the
> work and am pushing this:

After first squashing in this, to pass 'make check' again.

diff --git a/tests/misc/expr b/tests/misc/expr
index 10dd1c5..6c4280f 100755
--- a/tests/misc/expr
+++ b/tests/misc/expr
@@ -70,7 +70,7 @@ my @Tests =


      # This erroneously succeeded and output `3' before 2.0.12.
-     ['fail-a', '3 + -', {ERR => "$prog: non-numeric argument\n"},
+     ['fail-a', '3 + -', {ERR => "$prog: non-integer argument\n"},
       {EXIT => 2}],

      # This erroneously succeeded before 5.3.1.

-- 
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden

signature.asc
Description: OpenPGP digital signature