bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] sort.c: Fix minor memory leak, "files" is never free'd


From: Joey Degges
Subject: [PATCH] sort.c: Fix minor memory leak, "files" is never free'd
Date: Tue, 16 Feb 2010 01:02:24 -0800

Hello,

At sort.c:3271 'files' is allocated but it is not free'd before main exits:
    files = xnmalloc (argc, sizeof *files);

This patch frees files at the end of main().


>From 31ec4fb66f8b7fd15e2ef297b3de81f2b91da2f2 Mon Sep 17 00:00:00 2001
From: Joey Degges <address@hidden>
Date: Mon, 15 Feb 2010 23:30:31 -0800
Subject: [PATCH 1/3] Fix minor memory leak: files is never free'd

---
 src/sort.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/src/sort.c b/src/sort.c
index 481fdb8..4c6ca45 100644
--- a/src/sort.c
+++ b/src/sort.c
@@ -3692,6 +3692,9 @@ main (int argc, char **argv)
   else
     sort (files, nfiles, outfile);

+  if (nfiles != 0)
+    free (files);
+
   if (have_read_stdin && fclose (stdin) == EOF)
     die (_("close failed"), "-");

-- 
1.6.6.1


reply via email to

[Prev in Thread] Current Thread [Next in Thread]