bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: join with header line support


From: Eric Blake
Subject: Re: join with header line support
Date: Mon, 01 Feb 2010 07:19:38 -0700
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666

According to Pádraig Brady on 2/1/2010 7:08 AM:
> On 26/01/10 11:49, Pádraig Brady wrote:
>> There are 2 questions with this.
>>
>> 1. Since this is only specific to --check-order really, perhaps
>> we should add it as a parameter like --check-order=+N where N
>> is the number of lines to skip checks on, and output as header lines.

That actually sounds like a good idea, of accepting an optional argument
(defaulting to 0).  And it works well since --check-order has no short option.

>>
>> 2. Do we want to output headings from the first file
>> when they don't match the second?

I'm not as sure on this one.

>>
>> I'll push the attached patch (which has a few tweaks) in a while
>> unless others want changes as per the questions above.
> 
> Pushed.

Pushing was reasonable; such changes are good incrementally, anyways.

-- 
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]