bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] maint: fix an inconsequential mem leak in join


From: Pádraig Brady
Subject: Re: [PATCH] maint: fix an inconsequential mem leak in join
Date: Mon, 01 Feb 2010 14:09:29 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.7) Gecko/20100111 Thunderbird/3.0.1

On 27/01/10 16:18, Jim Meyering wrote:
Pádraig Brady wrote:
valgrind was complaining about definite mem leaks in `join`
so I refactored the offending code a little and removed the
inconseqential leak (which may mask real leaks in future).
...
Subject: [PATCH] maint: fix an inconsequential mem leak in join

* src/join.c (join): Refactor the code that checks for misorder
at the tail of the files.  The most significant change here is
that freeline() is called thus silencing a valgrind warning about
a definite but inconseqential memory leak.
(freeline): Make more general by doing nothing when passed NULL,
and setting freed pointers to NULL.

Thanks.  That had been an annoyance when looking at leak summaries.

pushed




reply via email to

[Prev in Thread] Current Thread [Next in Thread]