bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: How to make the colors different for a symbol link pointing to a fil


From: Jim Meyering
Subject: Re: How to make the colors different for a symbol link pointing to a file and symbol link pointing to a dir?
Date: Fri, 01 Jan 2010 16:12:57 +0100

Eric Blake wrote:
> According to Eric Blake on 1/1/2010 6:48 AM:
>> Ahh.  You have indeed discovered a real bug, still broken in the latest
>> git sources.
>> It is not a feature; we'll have it fixed for coreutils 8.3.
>
> How about the following patch (plus the omitted THANKS changes)?  This
> appears to have been broken since the introduction of 'LINK target' in
> commit 5c7059a, in Apr 2000.

Thanks for writing that.
I'll bet it's right, but I haven't looked carefully yet.

> I still need to figure out how to enhance the testsuite to catch this.
> Any hints on the best approach to take?

You might want to add one to tests/misc/ls-misc.
There are some there that already deal with dangling
symlinks and LS_COLORS settings.

IMHO, the perl-based tests are slightly cleaner than
the bourne-shell ones for this sort of thing.

> Obviously, the copyright hunk in the patch below is better handled by a
> mass update.  I'm assuming you'll take care of that shortly, Jim?

Yes, I'd already done it, but hadn't pushed.
Just did.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]