Re: [PATCH] df: add comments to help translators align column headers

[Jim Meyering]

Thanks.  I've tweaked things, so please review the result,
since it's still in your name:


>From 7d2dc630c09c2c4b599f1dd9a5379ddd058dd3f3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?St=C3=A9phane=20Raimbault?= <address@hidden>
Date: Thu, 31 Dec 2009 16:55:48 +0100
Subject: [PATCH 1/3] df: add comments to help translators align column headers

* src/df.c (print_header): Add a comment telling translators to
retain the message length, and another to align header translations.
---
 src/df.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/src/df.c b/src/df.c
index 411e61a..a80d795 100644
--- a/src/df.c
+++ b/src/df.c
@@ -148,11 +148,19 @@ print_header (void)
   char buf[MAX (LONGEST_HUMAN_READABLE + 1, INT_BUFSIZE_BOUND (uintmax_t))];

   if (print_type)
+    /* TRANSLATORS:
+       For best results (df header/column alignment), ensure that
+       your translation has the same length as the original.  */
     fputs (_("Filesystem    Type"), stdout);
   else
     fputs (_("Filesystem        "), stdout);

   if (inode_format)
+    /* TRANSLATORS:
+       For best results (df header/column alignment), ensure that
+       your translation has the same length as the original.
+       Also, each column name translation should end at the same
+       column as the corresponding original.  */
     printf (_("    Inodes   IUsed   IFree IUse%%"));
   else if (human_output_opts & human_autoscale)
     {
--
1.6.6.334.g442f


>From 426082c4296c6ede3e2c4de158b6425a94f17e8d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?St=C3=A9phane=20Raimbault?= <address@hidden>
Date: Thu, 31 Dec 2009 16:52:34 +0100
Subject: [PATCH 2/3] pr --help: improve a line-break

* src/pr.c (usage): Move the newline character a bit farther.
---
 src/pr.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/pr.c b/src/pr.c
index 40c35e4..9f445ee 100644
--- a/src/pr.c
+++ b/src/pr.c
@@ -2868,8 +2868,8 @@ Mandatory arguments to long options are mandatory for 
short options too.\n\
       fputs (VERSION_OPTION_DESCRIPTION, stdout);
       fputs (_("\
 \n\
--t is implied if PAGE_LENGTH <= 10.  With no FILE, or when\n\
-FILE is -, read standard input.\n\
+-t is implied if PAGE_LENGTH <= 10.  With no FILE, or when FILE is -, read\n\
+standard input.\n\
 "), stdout);
       emit_ancillary_info ();
     }
--
1.6.6.334.g442f


>From 38b32c3e53640e7895257ed4ec0d00a4c895bf17 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?St=C3=A9phane=20Raimbault?= <address@hidden>
Date: Thu, 31 Dec 2009 16:52:25 +0100
Subject: [PATCH 3/3] pr --help: add missing space between short and long 
options usage message

* src/pr.c (usage): Add missing space.
---
 src/pr.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/pr.c b/src/pr.c
index 9f445ee..f1b798a 100644
--- a/src/pr.c
+++ b/src/pr.c
@@ -2835,7 +2835,7 @@ Mandatory arguments to long options are mandatory for 
short options too.\n\
                     omit warning when a file cannot be opened\n\
 "), stdout);
       fputs (_("\
-  -s[CHAR],--separator[=CHAR]\n\
+  -s[CHAR], --separator[=CHAR]\n\
                     separate columns by a single character, default for CHAR\n\
                     is the <TAB> character without -w and \'no char\' with 
-w\n\
                     -s[CHAR] turns off line truncation of all 3 column\n\
--
1.6.6.334.g442f