Re: rm 8.1

[Jim Meyering]

Jim Meyering wrote:
> Ladislav Hagara wrote:
>> the behaviour of rm from last stable coreutils 8.1 is quite different
>> from previous 7.6 one.
> ....
>> Is this a bug or a new feature of rm 8.1?
>
> Thank you very much for the report!
> That is most definitely a bug.
>
> The fix has two parts:
...
> in coreutils:
>
>     rm: fix empty-name bug introduced with conversion to use fts
>
>     While "rm ''" would properly fail, "rm F1 '' F2" would fail
>     to remove F1 and F2, due to the empty string argument.
>     This bug was introduced on 2009-07-12, via commit 4f73ecaf,
>     "rm: rewrite to use fts".
>     * NEWS (Bug fixes): Describe it.
>     * tests/rm/empty-name: Adjust for changed diagnostic.
>     (mk_file): Define, copied from misc/ls-misc.
>     (empty-name-2): New test, for today's fix.
>     * lib/xfts.c (xfts_open): Reflect the change in fts_open, now that
>     it no longer fails immediately when one argument is the empty string.
>     Assert that the bit flags were not the cause of failure.
>     * po/POTFILES.in: Remove xfts.c.
>     * THANKS: Update.
>     Reported by Ladislav Hagara.
...
>>From b1b663c6f859e2c5008417101d16fcd57876e8ac Mon Sep 17 00:00:00 2001
> From: Jim Meyering <address@hidden>
> Date: Tue, 1 Dec 2009 12:02:11 +0100
> Subject: [PATCH] rm: fix empty-name bug introduced with conversion to use fts

I pushed that with one addition: it also updates gnulib
to the latest, and thus pulls in the fixed fts.c.