[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: don't let a fail=1 env. setting induce unwarranted te
|
From: |
Jim Meyering |
|
Subject: |
Re: [PATCH] tests: don't let a fail=1 env. setting induce unwarranted test failure |
|
Date: |
Thu, 29 Oct 2009 17:00:36 +0100 |
Eric Blake wrote:
> Jim Meyering <jim <at> meyering.net> writes:
>> This corrects all of them and adds a syntax-check rule
>> to ensure that no new instance is introduced.
>
> Why not factor the initialization of fail=0 into tests/test-lib.sh?
Yes, that is probably better.
Define the problem away, rather than add code to prevent it.
>> Fix the offenders:
>> * tests/cp/acl: Set file=0
>
> Typo. s/file=0/fail=0./
Thanks!