bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: env+nice, one bug fix, two test corrections


From: Jim Meyering
Subject: Re: env+nice, one bug fix, two test corrections
Date: Mon, 26 Oct 2009 22:30:57 +0100

Eric Blake wrote:

> Jim Meyering <jim <at> meyering.net> writes:
>
>> Wasn't that the intent of your original test?  To ensure
>> that the "-i" after "--" was interpreted as a program
>> name and not as an option?
>>
>> > I'll play with this some more and propose a patch later.
>>
>> Thanks!
>
> How do these look?

Looks good, but there was one failure:

  + test xfail = xfail
  ++ env sh -c '\c=d echo fail'
  sh: c=d: command not found
  + test x = xpass
  + fail=1

This is the offending line of tests/misc/env:

    test "x$(env sh -c '\c=d echo fail')" = xpass || fail=1

Compare these:

  $ env sh -c '\c=d echo fail'
  sh: c=d: command not found
  [Exit 127]
  $ env sh -c 'c=d echo fail'
  fail



> From: Eric Blake <address@hidden>
> Date: Mon, 26 Oct 2009 09:26:00 -0600
> Subject: [PATCH 1/2] env: document PATH interactions
>
> * doc/coreutils.texi (env invocation): Mention that PATH is
> modified prior to exec.
> * tests/misc/env: Test this.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]