Re: clean up library dependencies

[Jim Meyering]

Eric Blake wrote:
...
> I did, but it was an old enough machine that -lacl wasn't present, so
> configure disabled the attempt to do that link in the first place.  Sorry
> about that.

No harm.

>> diff --git a/src/Makefile.am b/src/Makefile.am
>> index ed7cc86..aee904f 100644
>> --- a/src/Makefile.am
>> +++ b/src/Makefile.am
>> @@ -273,6 +273,7 @@ su_LDADD += $(LIB_CRYPT)
>>  # for various ACL functions
>>  copy_LDADD += $(LIB_ACL)
>>  dir_LDADD += $(LIB_ACL)
>> +ls_LDADD += $(LIB_ACL)
>
> Hmm.  dir_LDADD is a no-op - it was previously assigned to be identical to

Yes.  Incrementing dir_LDADD here is a no-op.

> whatever the final ls_LDADD ends up being (ie. my bug was using dir_LDADD
> instead of the correct ls_LDADD).  Therefore, should I also apply this
> patch (just a diff for now)?
>
> diff --git a/src/Makefile.am b/src/Makefile.am
> index b4ff8da..915ea81 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -361,7 +361,6 @@ su_LDADD += $(LIB_CRYPT)
>
>  # for various ACL functions
>  copy_LDADD += $(LIB_ACL)
> -dir_LDADD += $(LIB_ACL)

Yes, that looks fine.
Thanks.