[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] cp, mv: do preserve extended attributes even for read-only s

From: Ondřej Vašík
Subject: Re: [PATCH] cp, mv: do preserve extended attributes even for read-only source files
Date: Mon, 14 Sep 2009 10:45:40 +0200

Pádraig Brady wrote:
> Since we're only doing u+rw, and we've already stat'd it's
> probably better to just (sb.mode & S_IWUSR) rather than access(...).
> Also a couple of the  if statements are indented too far.

Hopefully ok with the attached patch.

> This should now be safer but as Jim says it
> only effects file systems mounted user_xattr.
> Perhaps we should wait until coreutils-7.7 and
> also feedback from libattr devs so as we can put
> an accurate comment in the code.

As libattr feedback is already here at
and it seems it is not a bug in libattr (just strange requirement by
kernel), I modified the comment about workaround - as the culprit is
probably in kernel. 

         Ondřej Vašík

Attachment: cp-extended-attributes-readonly.patch
Description: Text Data

Attachment: signature.asc
Description: Toto je digitálně podepsaná část zprávy

reply via email to

[Prev in Thread] Current Thread [Next in Thread]