[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: new snapshot available: coreutils-7.5.65-61cc6

From: Eric Blake
Subject: Re: new snapshot available: coreutils-7.5.65-61cc6
Date: Mon, 07 Sep 2009 20:25:12 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20090812 Thunderbird/ Mnenhy/

Hash: SHA1

According to Pádraig Brady on 9/7/2009 6:32 PM:
>>> "fstatat.c", line 39: undefined symbol: AT_SYMLINK_NOFOLLOW
>> Hmm. That should be taken care of by the gnulib <fcntl.h> replacement.
>> Are we missing a #include?  Can you post the full failure?
> gnulib 52c658e seems to have removed #include "openat.h" from fstatat.c
> but not replaced it with #include <fcntl.h>

Yep; and only Solaris had the problem, because that is the only platform
with broken fstatat (the other platforms either lack it or it works
entirely).  Fixed as follows; coreutils needs to update the gnulib submodule.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

From 2c90f1af0fd6fcf444f5c16de9ff465651a854fc Mon Sep 17 00:00:00 2001
From: Eric Blake <address@hidden>
Date: Mon, 7 Sep 2009 20:16:00 -0600
Subject: [PATCH] fstatat: fix compilation on Solaris
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* lib/fstatat.c (includes): Add fcntl.h.
Reported by Pádraig Brady.

Signed-off-by: Eric Blake <address@hidden>
 ChangeLog     |    6 ++++++
 lib/fstatat.c |    1 +
 2 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 0b9e3a0..7df9226 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2009-09-08  Eric Blake  <address@hidden>
+       fstatat: fix compilation on Solaris
+       * lib/fstatat.c (includes): Add fcntl.h.
+       Reported by Pádraig Brady.
 2009-09-07  Eric Blake  <address@hidden>

        rename: modernize replacement
diff --git a/lib/fstatat.c b/lib/fstatat.c
index 2bf547e..9b0c1af 100644
--- a/lib/fstatat.c
+++ b/lib/fstatat.c
@@ -22,6 +22,7 @@
 #include <sys/stat.h>

 #include <errno.h>
+#include <fcntl.h>
 #include <string.h>

 #undef fstatat

reply via email to

[Prev in Thread] Current Thread [Next in Thread]