bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] fix libcap configure flag handling


From: Jim Meyering
Subject: Re: [PATCH] fix libcap configure flag handling
Date: Fri, 04 Sep 2009 08:50:32 +0200

Mike Frysinger wrote:
> The current libcap flag handler treats any libcap configure option as
> --disable-libcap because it doesn't check $enableval at all.  So make
> sure we do the sane thing:
>  --disable-libcap -> disable and don't run any tests
>  --enable-libcap -> run tests and fail if not found
>  <no choice> -> run tests and warn if not found

Thanks!  Pushed.
I tweaked your comment to make it look more like a ChangeLog entry:

    build: fix libcap configure flag handling

    * m4/jm-macros.m4 (coreutils_MACROS): The code to handle configure-time
    enabling or disabling of libcap support was broken.  It would treat any
    libcap configure option as --disable-libcap because it doesn't check
    $enableval at all.  This change makes sure we do the sane thing:
      --disable-libcap -> disable and don't run any tests
      --enable-libcap -> run tests and fail if not found
      default -> run tests and warn if not found




reply via email to

[Prev in Thread] Current Thread [Next in Thread]