[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ls -i: print consistent inode numbers also for mount points
From: |
Pádraig Brady |
Subject: |
Re: [PATCH] ls -i: print consistent inode numbers also for mount points |
Date: |
Mon, 31 Aug 2009 14:46:12 +0100 |
User-agent: |
Thunderbird 2.0.0.6 (X11/20071008) |
Ondřej Vašík wrote:
> Jim Meyering wrote:
>> Following up on a long thread from a year ago, here's a patch
>> to fix the 3.5-year-old readdir-vs-mountpoint-inode bug in ls -i.
>
> Checked on my system and works fine...
>
>> It's a shame to have to pessimize ls -i performance, even by this
>> small amount on linux-based kernels, but correctness definitely
>> trumps performance, here.
>
> Yep, it has some performance impact...
> checked `time ./ls -i1R /home /dev /usr /var /lib >myinodes with
> approximate number of 31k dirs, 450k files on ext3
>
> and results are
> old binary without the patch:
> real 2m5.631s
> user 0m3.012s
> sys 0m4.815s
>
> new binary:
> real 6m8.560s
> user 0m3.947s
> sys 0m30.572s
So there was a lot more disk access with the new binary.
but the NEWS suggests that should only be the case for
"systems with dysfunctional readdir".
What was your system?
thanks,
Pádraig.