[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: rm (remove.c): Rewrite to use fts: request for review
From: |
Jim Meyering |
Subject: |
Re: rm (remove.c): Rewrite to use fts: request for review |
Date: |
Sun, 30 Aug 2009 13:41:13 +0200 |
James Youngman wrote:
> On Fri, Aug 28, 2009 at 7:09 PM, Jim Meyering<address@hidden> wrote:
>> Here's an interesting patch.
> [...]
>> It'd be great if another pair of eyes could glance through
>> these changes (diffs look "big", but most hunks are simply removals).
>
> I read the patch, but don't have any comments. Partly this is because
> it is hard to get a sense of the new flow of the code by reading the
> patch only. I'd have to apply it and read the result, really. I
> will try to find time to do that too.
Thanks!
I agree that the patch by itself is illegible.
I find that applying a patch and then running Emacs' ediff-revision
is a good way to view highlighted side-by-side differences.