Re: three small patches

[Jim Meyering]

Pádraig Brady wrote:
> Jim Meyering wrote:
>> Subject: [PATCH 1/3] tests: cp/reflink-auto guard against a pathological 
>> $TMPDIR
>>
>> * tests/cp/reflink-auto: Add quotes.
>>
>> diff --git a/tests/cp/reflink-auto b/tests/cp/reflink-auto
>> index ff2b1b3..d1f6b2b 100755
>> --- a/tests/cp/reflink-auto
>> +++ b/tests/cp/reflink-auto
>> @@ -26,7 +26,7 @@ fi
>>  cleanup_() { rm -rf "$other_partition_tmpdir"; }
>>  . "$abs_srcdir/other-fs-tmpdir"
>>  a_other="$other_partition_tmpdir/a"
>> -rm -f $a_other || framework_failure
>> +rm -f "$a_other" || framework_failure
>
> I'd copied that hunk from misc/xattr which had
> copied it from elsewhere. So I've fixed those up
> also along with another few I noticed.
>
> The attached patch passes all tests.
...
> diff --git a/tests/misc/xattr b/tests/misc/xattr
...
>  if test $test_mv -eq 1; then
>    # mv should preserve xattr when copying content from one partition to 
> another
> -  mv b $b_other || fail=1
> -  getfattr -d $b_other >out_b 2>/dev/null || skip_test_ "failed to get xattr 
> of file"
> +  mv b "$b_other" || fail=1
> +  getfattr -d "$b_other" >out_b 2>/dev/null || skip_test_ "failed to get 
> xattr of file"
>    grep -F "$xattr_pair" out_b >/dev/null || fail=1

Thanks for doing that.
Those changes look fine.  Though please split the long line, above.