bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: AW: AW: AW: new snapshot available: coreutils-7.4.125-eca6


From: Jim Meyering
Subject: Re: AW: AW: AW: new snapshot available: coreutils-7.4.125-eca6
Date: Tue, 18 Aug 2009 17:55:58 +0200

Voelker, Bernhard wrote:
> Jim Meyering wrote:
>> Here's a tarball with those two not-yet-pushed changes:
>
> Now, `make check` works ... mostly.
>
> I attached the 2 logfiles - 1 run as root, 1 run as non-root.
> It seems that the test-suite sometimes relies on GNU coreutils
> like rm or mv in the path instead of the fresh compiled ones.
...
> FAIL: misc/stdbuf (exit: 1)
> ===========================
>
> ./misc/stdbuf: line 27: skip_test_: command not found


That one's easy.
My fault for using skip_test_ before it's defined:

>From 6f6599a006e08c0e7a0825f1f059fde66d2847b5 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Tue, 18 Aug 2009 17:53:20 +0200
Subject: [PATCH] tests: stdbuf: fix a bug in test script

* tests/misc/stdbuf: Use skip_test_ only after it's defined.
Reported by Berhnard Voelker.

(sc_check-AUTHORS): Rename rule from check-AUTHORS.
---
 tests/misc/stdbuf |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/misc/stdbuf b/tests/misc/stdbuf
index 5ce2c11..a9aed43 100755
--- a/tests/misc/stdbuf
+++ b/tests/misc/stdbuf
@@ -21,15 +21,15 @@ if test "$VERBOSE" = yes; then
   stdbuf --version
 fi

+. $srcdir/test-lib.sh
+getlimits_
+
 # skip this test if stdbuf isn't being built.
 case " $built_programs " in
   *" stdbuf "*) ;;
   *) skip_test_ 'stdbuf not built';;
 esac

-. $srcdir/test-lib.sh
-getlimits_
-
 # Use a fifo rather than a pipe in the tests below
 # so that the producer (uniq) will wait until the
 # consumer (dd) opens the fifo therefore increasing
--
1.6.4.378.g88f2f

> FAIL: install/install-C (exit: 1)
> =================================
>
> cmp: EOF on out
> ginstall: options --compare (-C) and --preserve-timestamps are mutually 
> exclusive
> Try `ginstall --help' for more information.
> ginstall: options --compare (-C) and --strip are mutually exclusive
> Try `ginstall --help' for more information.

I don't see the cause of this one, yet.
Please rerun it in verbose mode:

    make check -C tests TESTS=install/install-C VERBOSE=yes




reply via email to

[Prev in Thread] Current Thread [Next in Thread]