Re: BTRFS file clone support for cp

[Jim Meyering]

Pádraig Brady wrote:

> Giuseppe Scrivano wrote:
>> Pádraig Brady <address@hidden> writes:
>>
>>>> +#expensive_
>>> That comment is just for testing I presume?
>>> Note you can run a single expensive test like:
>>> (cd tests && make check TESTS=cp/file-clone VERBOSE=yes 
>>> RUN_EXPENSIVE_TESTS=yes)
>>
>> sorry, yes I commented it out only for testing purpose.  If you think
>> the rest is fine and want to push it, can you please amend my commit?
>
> Sure I'll fix it up from here.
> I'll not push yet though, until the interface settles down.
> I.E. we'll probably need to be calling {cp,ln} --reflink instead.

Thanks for dealing with that.
IMHO, a root-only test does not merit an "expensive" tag,
unless it does something very extreme.

My goal in using these tags is to make it so that the default
"make check" is reasonably quick, and not too abusive
in a multi-user environment.  When someone deliberately
runs the root-only tests, they can be expected to endure
some reasonable delays.