bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

test and doc tweaks


From: Jim Meyering
Subject: test and doc tweaks
Date: Tue, 23 Jun 2009 16:56:19 +0200

I noticed the tail-2/pid test fail recently (racy?) but couldn't reproduce it.

>From fc66fb4d99f2c7e71fadc85e2be476e817b6573e Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Tue, 23 Jun 2009 16:53:43 +0200
Subject: [PATCH 1/2] tests: tail-2/pid: include more info upon failure

* tests/tail-2/pid: Print unexpected $state upon failing.
---
 tests/tail-2/pid |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tests/tail-2/pid b/tests/tail-2/pid
index ff2f099..9d33e4f 100755
--- a/tests/tail-2/pid
+++ b/tests/tail-2/pid
@@ -46,7 +46,7 @@ state=$(get_process_status_ $pid)
 if test -n "$state"; then
   case $state in
     S*) ;;
-    *) echo $0: process dead 1>&2; fail=1 ;;
+    *) echo "$0: process dead? (state=$state)" 1>&2; fail=1 ;;
   esac
   kill $pid
 fi
--
1.6.3.3.420.gd4b46


>From f9554bbe25bc7d979926628655713a9c0ddc6dbb Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Tue, 23 Jun 2009 16:54:38 +0200
Subject: [PATCH 2/2] doc: README-hacking tweak

* README-hacking: Move the "While building..." sentence down
to where it belongs.
---
 README-hacking |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/README-hacking b/README-hacking
index 9deba13..555128f 100644
--- a/README-hacking
+++ b/README-hacking
@@ -23,9 +23,6 @@ bootstrap script shown below, and will include:
 - Rsync <http://samba.anu.edu.au/rsync/>
 - Tar <http://www.gnu.org/software/tar/>

-While building from a just-cloned source tree may require installing a
-few prerequisites, later, a plain `git pull && make' should be sufficient.
-
 - Valgrind

 Valgrind <http://valgrind.org/> is also highly recommended, if
@@ -39,6 +36,9 @@ version 1.10a or newer, as well as the xz program itself.
 Make sure you have the latest version of the XZ Utils from
 <http://tukaani.org/xz/>

+While building from a just-cloned source tree may require installing a
+few prerequisites, later, a plain `git pull && make' should be sufficient.
+
 * First GIT checkout

 You can get a copy of the source repository like this:
--
1.6.3.3.420.gd4b46




reply via email to

[Prev in Thread] Current Thread [Next in Thread]