Re: new snapshot available: coreutils-7.2.66-428db1

[Jim Meyering]

James Youngman wrote:
> "make check" fails in "doc" on a vanilla NetBSD5.0 system (released
> yesterday) because no version of Perl is installed by default.   In
> fact make fails without explanation:
>
> $ make check
> *** Error code 1
>
> Stop.
> make: stopped in /home/james/tmp/cu/coreutils-7.2.66-428db1/doc
>
>
> I guess this is because some failing command starts with @.   Anyway,
> re-running with make debugging turned on, we find that the problem is
> that although configure determined that Perl was missing, it still
> decides to run it:

Hi James,

Thanks for reporting that, and especially for testing on a
just-released system!

The second change set below should fix that.

>From 71ebb443d816caad6f4142403d57711d8bf2205e Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Thu, 30 Apr 2009 13:44:48 +0200
Subject: [PATCH 1/2] build: doc: emit something for each "make check"-run rule

* doc/Makefile.am: Use $(AM_V_GEN) in place of each leading "@".
(check-texinfo): Align line-continuation backslashes.
---
 doc/Makefile.am |   38 +++++++++++++++++++-------------------
 1 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/doc/Makefile.am b/doc/Makefile.am
index 89f72ce..57063df 100644
--- a/doc/Makefile.am
+++ b/doc/Makefile.am
@@ -60,45 +60,45 @@ syntax_checks =             \

 # List words/regexps here that should not appear in the texinfo documentation.
 check-texinfo: $(syntax_checks)
-       @fail=0; \
-       grep '@url{' $(srcdir)/*.texi && fail=1; \
-       grep '\$$@"' $(srcdir)/*.texi && fail=1; \
-       grep -n '[^[:punct:address@hidden' $(srcdir)/*.texi && fail=1; \
-       grep -n filename $(srcdir)/*.texi \
-           | $(EGREP) -v 'setfilename|[{]filename[}]' \
-         && fail=1; \
-       $(PERL) -e 1 2> /dev/null && { $(PERL) -ne \
+       $(AM_V_GEN)fail=0;                                              \
+       grep '@url{' $(srcdir)/*.texi && fail=1;                        \
+       grep '\$$@"' $(srcdir)/*.texi && fail=1;                        \
+       grep -n '[^[:punct:address@hidden' $(srcdir)/*.texi && fail=1;  \
+       grep -n filename $(srcdir)/*.texi                               \
+           | $(EGREP) -v 'setfilename|[{]filename[}]'                  \
+         && fail=1;                                                    \
+       $(PERL) -e 1 2> /dev/null && { $(PERL) -ne                      \
          '/\bPOSIX\b/ && !/address@hidden/ && !/^\* / || /{posix}/ and 
print,exit 1' \
-         $(srcdir)/*.texi 2> /dev/null || fail=1; }; \
-       $(EGREP) -i '$(_W)builtins?$(W_)' $(srcdir)/*.texi && fail=1; \
-       $(EGREP) -i '$(_W)path(name)?s?$(W_)' $(srcdir)/*.texi \
+         $(srcdir)/*.texi 2> /dev/null || fail=1; };                   \
+       $(EGREP) -i '$(_W)builtins?$(W_)' $(srcdir)/*.texi && fail=1;   \
+       $(EGREP) -i '$(_W)path(name)?s?$(W_)' $(srcdir)/*.texi          \
          | $(EGREP) -v 'search path|@vindex PATH$$|@env[{]PATH[}]' && fail=1; \
        exit $$fail

 # Use `time zone', not `timezone'.
 sc-avoid-timezone:
-       @$(EGREP) timezone $(srcdir)/*.texi && exit 1 || :
+       $(AM_V_GEN)$(EGREP) timezone $(srcdir)/*.texi && exit 1 || :

 # Check for insufficient exponent grouping, e.g.,
 # @math{2^64} should be @math{2^{64}}.
 sc-exponent-grouping:
-       @$(EGREP) '\{.*\^[0-9][0-9]' $(srcdir)/*.texi && exit 1 || :
+       $(AM_V_GEN)$(EGREP) '\{.*\^[0-9][0-9]' $(srcdir)/*.texi && exit 1 || :

 # E.g., use @sc{nul}, not NUL.
 sc-use-small-caps-NUL:
-       @$(EGREP) '$(_W)NUL$(W_)' $(srcdir)/*.texi && exit 1 || :
+       $(AM_V_GEN)$(EGREP) '$(_W)NUL$(W_)' $(srcdir)/*.texi && exit 1 || :

 # Say I/O, not IO.
 sc-avoid-io:
-       @$(EGREP) '$(_W)IO$(W_)' $(srcdir)/*.texi && exit 1 || :
+       $(AM_V_GEN)$(EGREP) '$(_W)IO$(W_)' $(srcdir)/*.texi && exit 1 || :

 # I prefer nonzero over non-zero.
 sc-avoid-non-zero:
-       @$(EGREP) non-zero $(srcdir)/*.texi && exit 1 || :
+       $(AM_V_GEN)$(EGREP) non-zero $(srcdir)/*.texi && exit 1 || :

 # Use `zeros', not `zeroes' (nothing wrong with `zeroes'. just be consistent).
 sc-avoid-zeroes:
-       @$(EGREP) -i '$(_W)zeroes$(W_)' $(srcdir)/*.texi && exit 1 || :
+       $(AM_V_GEN)$(EGREP) -i '$(_W)zeroes$(W_)' $(srcdir)/*.texi && exit 1 || 
:

 # ME = $(subdir)/$(word $(words $(MAKEFILE_LIST)),$(MAKEFILE_LIST))
 ME = doc/Makefile
@@ -115,7 +115,7 @@ find_upper_case_var =               \
      }                         \
    END {$$m and (warn "$(ME): do not use upper case in address@hidden"), exit 
1}'
 sc-lower-case-var:
-       @$(PERL) -e 1 2> /dev/null && \
-         $(PERL) -lne $(find_upper_case_var) $(srcdir)/*.texi
+       $(AM_V_GEN)$(PERL) -e 1 2> /dev/null \
+         && $(PERL) -lne $(find_upper_case_var) $(srcdir)/*.texi

 check: check-texinfo
--
1.6.3.rc3.212.g8c698


>From 0e945ebcc5cb018771819f8b91737db3298bab02 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Thu, 30 Apr 2009 13:50:40 +0200
Subject: [PATCH 2/2] build: "make check" now fails in a friendlier manner for 
missing Perl

* doc/Makefile.am (sc-lower-case-var): Don't redirect stderr of
$(PERL) (which is sometimes build-aux/missing) to /dev/null,
so that a failing "make check" explains that Perl is not installed.
Reported by James Youngman.
---
 doc/Makefile.am |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/doc/Makefile.am b/doc/Makefile.am
index 57063df..be610a2 100644
--- a/doc/Makefile.am
+++ b/doc/Makefile.am
@@ -115,7 +115,7 @@ find_upper_case_var =               \
      }                         \
    END {$$m and (warn "$(ME): do not use upper case in address@hidden"), exit 
1}'
 sc-lower-case-var:
-       $(AM_V_GEN)$(PERL) -e 1 2> /dev/null \
+       $(AM_V_GEN)$(PERL) -e 1 \
          && $(PERL) -lne $(find_upper_case_var) $(srcdir)/*.texi

 check: check-texinfo
--
1.6.3.rc3.212.g8c698