Re: cp(1) fails to copy file from /proc

[James Youngman]

On Fri, Apr 17, 2009 at 5:46 PM, Jim Meyering <address@hidden> wrote:
> diff --git a/src/copy.c b/src/copy.c
> index 9b0e139..3cbeba4 100644
> --- a/src/copy.c
> +++ b/src/copy.c
> @@ -699,10 +699,6 @@ copy_reg (char const *src_name, char const *dst_name,
>                goto close_src_and_dst_desc;
>              }
>            last_write_made_hole = false;
> -
> -           /* A short read on a regular file means EOF.  */
> -           if (n_read != buf_size && S_ISREG (src_open_sb.st_mode))
> -             break;
>          }
>       }
>

The patch itself looks good, but it might be worth leaving in a
comment indicating why the optimisation should not be reintroduced...

James.