[PATCH] tests: other-fs-tmpdir: avoid bogus "skipped **********..." diagnostic

[Jim Meyering]

Building on a system with /tmp, /var/tmp, $HOME, etc all on the same
partition, I saw a bunch of bogus diagnostics from "make check":

  ./mv/part-rename: skipping test: **************************************
  SKIP: mv/part-fail
  SKIP: mv/part-rename
  ./mv/part-hardlink: skipping test: **************************************
  SKIP: mv/part-hardlink
  PASS: mv/perm-1
  ./mv/part-symlink: skipping test: **************************************
  PASS: mv/no-target-dir
  ./mv/partition-perm: skipping test: **************************************
  SKIP: mv/partition-perm
  SKIP: mv/part-symlink
  ./mv/to-symlink: skipping test: **************************************

Here's the fix.
Now, each would say this:
  requires a writable directory on a different disk partition,
in place of the asterisks.

>From d99c479311a006391485e1c0e351715d2bd279b7 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sun, 29 Mar 2009 09:59:23 +0200
Subject: [PATCH] tests: other-fs-tmpdir: avoid bogus "skipped **********..." 
diagnostic

* tests/other-fs-tmpdir (CANDIDATE_TMP_DIRS): Add /dev/shm to the list.
Don't use a line of asterisks as the first line of the "why skipped"
diagnostic, now that that line is printed on 'make check's stderr.
---
 tests/other-fs-tmpdir |   13 ++++++-------
 1 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/tests/other-fs-tmpdir b/tests/other-fs-tmpdir
index a56f7b1..8850857 100644
--- a/tests/other-fs-tmpdir
+++ b/tests/other-fs-tmpdir
@@ -4,7 +4,8 @@
 # of the current directory.  If one is found, create a temporary directory
 # inside it.

-# Copyright (C) 1998, 1999, 2001, 2002, 2005, 2007-2008 Free Software 
Foundation, Inc.
+# Copyright (C) 1998, 1999, 2001, 2002, 2005, 2007-2009
+# Free Software Foundation, Inc.

 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -20,7 +21,7 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.

 test "${CANDIDATE_TMP_DIRS+set}" = set \
-  || CANDIDATE_TMP_DIRS="$TMPDIR /tmp /var/tmp /usr/tmp $HOME"
+  || CANDIDATE_TMP_DIRS="$TMPDIR /tmp /dev/shm /var/tmp /usr/tmp /usr/tmp 
$HOME"

 other_partition_tmpdir=

@@ -45,13 +46,11 @@ done

 if test -z "$other_partition_tmpdir"; then
   skip_test_ \
-"**************************************
-This test requires a writable directory on a different
-disk partition, and I couldn't find one.  I tried these:
+"requires a writable directory on a different disk partition,
+and I couldn't find one.  I tried these:
   $CANDIDATE_TMP_DIRS
 Set your environment variable CANDIDATE_TMP_DIRS to make
-this test use a different list.
-**************************************"
+this test use a different list."
 fi

 test "$VERBOSE" = yes && set -x
--
1.6.2.rc1.285.gc5f54