bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: misalignment in ls -l in fr_FR locale


From: Jim Meyering
Subject: Re: misalignment in ls -l in fr_FR locale
Date: Thu, 26 Mar 2009 13:17:29 +0100

Pádraig Brady wrote:
> Jim Meyering wrote:
>>> +   the trailing NUL).  A value >= dest_size means there wasn't enough 
>>> space.
>>> +   The width parameter both specifies the width to align/pad/truncate to,
>>> +   and is updated to return the width used before padding.  */
>>
>> Would "desired_width" be a better parameter name for dest_size?
>> "size" makes me think of a buffer size, i.e., number of bytes allocated.
>
> Good, as it is a buffer size :)
> The width parameter specifies the screen width.

Good, indeed ;-)

Thanks for the quick changes.
Two more requests:
  - there are several remaining "int" variables that should be size_t.
  - please don't declare more than one variable on a line.

Is this still needed?

  #include "xalloc.h"




reply via email to

[Prev in Thread] Current Thread [Next in Thread]