bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: cat fionread usage bug?


From: Jim Meyering
Subject: Re: cat fionread usage bug?
Date: Wed, 11 Mar 2009 13:30:56 +0100

Pádraig Brady wrote:
> Jim Meyering wrote:
>>>> Would you like to handle it?
>>> will do
>
> attached
>>From 5af58e0557198c464f39a2a0939c37941fdfd668 Mon Sep 17 00:00:00 2001
> From: =?utf-8?q?P=C3=A1draig=20Brady?= <address@hidden>
> Date: Wed, 11 Mar 2009 11:39:33 +0000
> Subject: [PATCH] cat: Fix immediate output of processed data
>
> * NEWS: Mention the bugfix.
> * src/cat.c (cat): Fix the typo which stopped the writing
> of processed data before a blocking read() is done.
> * tests/misc/cat-buf: Add to ensure processed data is not buffered.

Looks fine.  Thanks again.

Would you please include here, in the log, the SHA1 that
introduces the bug?  i.e.,

Introduced by commit 790892db, 2006-06-08 "Ensure that cat works ...".

> ---
>  NEWS               |    5 +++++
>  src/cat.c          |    2 +-
>  tests/misc/cat-buf |   41 +++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 47 insertions(+), 1 deletions(-)
>  create mode 100755 tests/misc/cat-buf
>
> diff --git a/NEWS b/NEWS
> index fd101a4..752173d 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -4,6 +4,11 @@ GNU coreutils NEWS                                    -*- 
> outline -*-
>
>  ** Bug fixes
>
> +  cat once again immediately outputs data it has processed.
> +  Previously it would have been buffered and only output if enough
> +  data was read, or on process exit.
> +  [bug introduced in coreutils-6.0]
...




reply via email to

[Prev in Thread] Current Thread [Next in Thread]